-
-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bugfix] webpack-cli init loader's test regex #1309
Conversation
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
Hi! Thank you for your contribution! Could you sign the license agreement please? |
Leaving this here for posterity: if you, like me, are having problems where Apparently, Webpack configs generated by a buggy version of this init tool where both |
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
no
If relevant, did you update the documentation?
no
Summary
Fixed the
regular expression
of loader'stest
field inwebpack.config.js
generated bywebpack-cli init
Does this PR introduce a breaking change?
no
Other information
the regex should be
\.jsx?$
or\.(js|jsx)$
, the original string should be"/\\.(js|jsx)$/"
instead of/.(js|jsx)$/
the same with
"/.(ts|tsx)?$/"
->"/\\.(ts|tsx)$/"