Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(GroupHelper): minor tweak #1059

Merged

Conversation

jamesgeorge007
Copy link
Member

@jamesgeorge007 jamesgeorge007 commented Aug 23, 2019

What kind of change does this PR introduce?
refactoring

Did you add tests for your changes?
Nope

If relevant, did you update the documentation?
N/A

Summary
Beautify code.

Does this PR introduce a breaking change?
Nope

Other information
N/A

@jamesgeorge007 jamesgeorge007 requested a review from a team as a code owner August 23, 2019 14:46
@jamesgeorge007 jamesgeorge007 changed the title chore(GroupHelper): drop extraneous block chore(GroupHelper): avoid extraneous check Aug 23, 2019
@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@jamesgeorge007 jamesgeorge007 changed the title chore(GroupHelper): avoid extraneous check chore(GroupHelper): minor tweak Aug 23, 2019
@evenstensberg evenstensberg merged commit 0f9c649 into webpack:next Aug 26, 2019
@jamesgeorge007 jamesgeorge007 deleted the feat/remove-extraneous-block branch August 26, 2019 15:10
@endiliey endiliey mentioned this pull request Nov 22, 2019
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants