Webpack-CLI version 1 #105

evenstensberg · 2017-04-07T11:56:12Z

Webpack CLI version 1

AST's
Prettier
Windows support
Documentation
Tests
Generator with adapter for us later to use for path validation before sending to AST's

pksjce · 2017-04-07T12:41:15Z

lib/creator/transformations/index.js

+const transformsObject = {
+	entryTransform,
+	outputTransform
+};


This should be passed to runTransform somehow.

Doing through p-lazy I suppose ;)

Don't review yet, will notify when there's something better to review, this isn't nearly done at all

evenstensberg · 2017-04-07T21:28:20Z

lib/creator/transformations/output/output.js

+	if(!webpackProperties['output']) {
+		return ast;
+	} else if(webpackProperties['output'].length) {
+		throw new Error('Supplying output with only no options is not supported.');


Remind me to change this l8tr :)

pksjce · 2017-04-09T10:18:36Z

Awesome work @ev1stensberg
^following

Thanks to Sindre Sørhus for this fix. Object references are now making sure our callbacks are held, and removed the return of the promise and rather used the object we want to return.

okonet · 2017-05-04T21:34:33Z

lib/creator/yeoman/utils/entry.js

@@ -6,44 +6,32 @@ module.exports = (self, answer) => {

 		let entryIdentifiers;
 		let entryProperties;
-		if(answer['entryType'].indexOf('Array') >= 0) {
+		if(answer['entryType'] == 'Multiple') {


== -> ===

okonet · 2017-05-04T21:35:25Z

lib/creator/yeoman/utils/entry.js

 					}
 					resolve(webpackEntryPoint);
 				});
 			});
 		}
 		else {
 			self.prompt([
-				Input('singularEntry', 'What\'s your entry point?')
+				Input('singularEntry', 'Write the location of module you would like to use')


I'm not sure write is a good verb here. I'd say type?

okonet · 2017-05-04T21:36:09Z

lib/creator/yeoman/webpack-generator.js

 		this.configuration.config.webpackOptions.module = getDefaultLoaders();
 		this.configuration.config.webpackOptions.plugins = getDefaultPlugins();
 		this.prompt([
-			RawList('entryType', 'What kind of entry point do you want?', ['Array', 'Function', 'String', 'Object'])
+			RawList('entryType', 'Would you like to bundle a single or multiple javascript modules?',


Please put each argument on a new line

pksjce · 2017-05-05T17:43:01Z

Hey,
Lot's of work done on this! Great to have more eyes on this code!

@ev1stensberg - I checked out the latest and ran webpack-cli --init to see usage. I have a few small concerns.
Here is the screenshot.

Asking to add "Remember to add string quotes to your bundle entries and file extensions!" is a bit much. Since it's only an init tool, we need not support too many complex options. We can just assume that what the user has entered is a string. Don't you think so?
" Would you like to bundle a single or multiple javascript modules?" could be simplfied to "Will you be creating multiple bundles?" with "Yes" or "No" answer.
"Type the location of module you would like to use" . This is a bit vague and we need to use simpler terminology.
Once all the prompts are answered, before the npm install runs, lets show a message saying "Created config, installing dependencies..." or something like that?

But, I would suggest an alternate set of questions to ask. The script would be something like

Welcome to webpack! 
We will ask you a few questions to create your configuration file.

1. Enter the name of your entry file - index.js
2. Enter the path for the output file - dist/bundle.js
3. Do you use ES6 in your project? Y/n
4. Do you use one of the below CSS solutions?
a. SASS
b. LESS
c. PostCss
5. Do you want to bundle the CSS to a separate file? Y/n

Creating "webpack.config.js"

module.exports = {
...
}

Do you want to save this file and install dependencies? Y/n
Installing dependencies....
..
..

Congratulations! Your configuration file has been created at `webpack,config.js`

I feel we have the ast support to convert all the above questions to a configuration. This should suffice to be the default init functionality.

Plugin packages could extend these questions to include framework/library specific questions like preact/react etc.

evenstensberg · 2017-05-05T21:14:40Z

@pksjce Hi! Great to have you reviewing!

Here's my replies to your concerns:

I feel like we should warn the user, or at least mention it in the docs somewhere. I don't really want to change the entries section, unless it's really needed. The reason is that we are with this logic allowing:

CommonChunkPlugin on multiple entries by default
Tooltip for CommonsChunk as well, to help users get a notion of perf, continued from a discussion and mention of this with @addyosmani
Super dynamic scaffolding for entries, people can add all sorts of types, and reminding people to add quotes is a small disadvantage.

We can, however, try to implement the string addition and remove this burden from the users. Not guaranteeing it will work 100%, but I'll try implementing it along with file-extensions for single entries. I was thinking about consistency when adding the file end note.

I completely agree, will proceed to replace
Yes, same here
Agree on this point too, this is consistent with migrate and allows people to reconsider.

For the CSS part, will refactor. Do you have a chance to review the ast part too?

Edit: I'm not sure if beginners know what those are, we should stick with CSS only and ask for feedback from the community, perhaps?

A question for me is: What is missing after the fixes mentioned to merge and push v1?

evenstensberg · 2017-05-05T22:14:17Z

A small note to add is that migrate uses a task runner for a single webpack.config. I'm a bit worried about this, as we support multiple package scaffolds in init, which will make the terminal polluted. Perhaps we should ask if the user wants to write the file instead? Can try to integrate the task-runner, but again, no promises. Fixed what you mentioned, except the CSS part, where we need to discuss.

Typing entry now lets you add things such as Array, Function, ArrowFunction, String and properties on strings that aren't litteral, such as path.join or process.cwd().

addyosmani · 2017-05-07T05:32:25Z

Fwiw, the proposal by @pksjce in "But, I would suggest an alternate set of questions to ask. The script would be something like" sounds like it would tweak the prompts to be a little more beginner friendly. Perhaps 'Do you use ES2015 in your project?' instead of ES6 :)

Silly question: why wouldn't the user want to create their Webpack config in the last step of 0ba9d7d? It seems extraneous to me. At least with Yeoman generators, the UX we typically use is asking questions and on the final question then kicking of writing to disk.

Reading through @ev1stensberg's work in c58f793, I do like the idea of minimal boilerplate for encouraging the use of common vendor chunks and ExtractTextPlugin.

Another silly q: To what extent if any should we be switching over to babel-minify if the user opts for ES2015 support with Babel? Are we encouraging ES2015 -> ES5 -> Uglify that code?

evenstensberg · 2017-05-07T10:38:02Z

@pksjce @addyosmani Corrected the generator as of the comments. The last thing left is the CSS/SASS/LESS prompts, do we want those? I'm not sure, but open for input. Removed the confirm, even though I side with @pksjce on the confirm part, as this is consistent with migrate.

Also, I think we should enable extractTextPlugin by default and skip the bundle CSS in one file, this is better for perf, yes?

evenstensberg · 2017-05-07T10:44:07Z

Also, heard some things about babel-minify resulting in a bigger bundle, or something in that alley. Pinging @kdzwinel for his input.

kdzwinel · 2017-05-07T22:53:05Z

Yeah, we did some tests couple of weeks back - babili wasn't terribly bigger (~10%), but it was way slower than babel+uglify.

Babel + uglify:
23.87s - 1.06 MB

Babili:
49.24s - 1.18 MB

This may have changed in the meantime though (babili is a beta project after all).

addyosmani · 2017-05-08T03:49:29Z

cc @hzoo as an fyi on the babili part of the discussion

👍 for the current status of this work landing @ev1stensberg

Also, I think we should enable extractTextPlugin by default and skip the bundle CSS in one file, this is better for perf, yes?

👍

anyulled · 2017-05-23T11:41:30Z

migrate.md file is empty. Is it intentional?

evenstensberg · 2017-06-19T22:11:36Z

@anyulled Yep, left it for @okonet or @pksjce , but this could be a good first contribution!

feat: initial commit on last structure and transforms

fa41989

pksjce suggested changes Apr 7, 2017

View reviewed changes

evenstensberg added Init enhancement AST Transform v1 labels Apr 7, 2017

evenstensberg added this to the v1 milestone Apr 7, 2017

evenstensberg added 3 commits April 7, 2017 19:42

feat: ast for entry

4cc5d94

feat: ast for output

ad3164e

feat: ast for context

9ce2873

evenstensberg commented Apr 7, 2017

View reviewed changes

evenstensberg added 5 commits April 8, 2017 14:49

feat: work in progress on resolve

c053082

feat: add transform structure for all

9635c96

fix: remove rx from the project

f92af9c

fix: return ast on no prop at resolve

9977025

feat: ast for resolve

2c6d1de

evenstensberg added 13 commits April 9, 2017 12:34

feat: ast for devtool

00e1eca

feat: art for target

7f8da31

feat: ast for watch

22df329

feat: sat for watchOptions

743f10f

fix: rename dev-tool to devtool

423b8cb

feat: ast for externals

2f7a10c

feat: ast for node

a2b9807

feat: sat for performance

9d5ebbe

feat: ast for stats

97c627d

feat: ast for other

29d0c56

feat: allow multiple packages in CLI command

bc6e1de

feat: allow dynamic entry points

8153f2b

feat: allow promises as entry points

3c7b021

enhancements: revise anti pattern for promise

663133a

Thanks to Sindre Sørhus for this fix. Object references are now making sure our callbacks are held, and removed the return of the promise and rather used the object we want to return.

okonet suggested changes May 4, 2017

View reviewed changes

evenstensberg added 2 commits May 5, 2017 14:45

enhancements: rename write to type and split params to newline

907a1f7

enhancements: add better scaffold to generator

c58f793

evenstensberg added 2 commits May 6, 2017 00:14

enhancements: make default generator more User Friendly

3e6115a

enhancements: ask if user wants to make the config at end

0ba9d7d

This was referenced May 6, 2017

Feature: Init transformations #29

Closed

Rename flag --migrate to a command (migrate) #89

Closed

Scoping: A typical webpack-addon-[name] package #42

Closed

enhancements: make default generator better

c6bd40c

evenstensberg added 2 commits May 7, 2017 18:41

enhancements: add styling option to generator

a9ea433

fix: remove sourceMap from postcss prop

bc24b9e

evenstensberg force-pushed the feature/init-ast branch from d24f50d to bc24b9e Compare May 7, 2017 17:18

evenstensberg added 5 commits May 7, 2017 20:23

enhancements: separate dev and prod build

f4add5a

enhancements: add contentHash & name

c766779

enhancements: prompt for better answers

ef05928

fix: remove unused module

2e2a38f

chore: final fixes before release

dd9b894

evenstensberg merged commit 302200d into master May 7, 2017

evenstensberg deleted the feature/init-ast branch May 8, 2017 13:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Webpack-CLI version 1 #105

Webpack-CLI version 1 #105

evenstensberg commented Apr 7, 2017 •

edited

Loading

pksjce Apr 7, 2017

evenstensberg Apr 7, 2017

evenstensberg Apr 7, 2017

evenstensberg Apr 7, 2017

pksjce commented Apr 9, 2017

okonet May 4, 2017

okonet May 4, 2017

okonet May 4, 2017

pksjce commented May 5, 2017

evenstensberg commented May 5, 2017 •

edited

Loading

evenstensberg commented May 5, 2017

addyosmani commented May 7, 2017

evenstensberg commented May 7, 2017 •

edited

Loading

evenstensberg commented May 7, 2017

kdzwinel commented May 7, 2017

addyosmani commented May 8, 2017

anyulled commented May 23, 2017

evenstensberg commented Jun 19, 2017

Webpack-CLI version 1 #105

Webpack-CLI version 1 #105

Conversation

evenstensberg commented Apr 7, 2017 • edited Loading

Webpack CLI version 1

pksjce Apr 7, 2017

Choose a reason for hiding this comment

evenstensberg Apr 7, 2017

Choose a reason for hiding this comment

evenstensberg Apr 7, 2017

Choose a reason for hiding this comment

evenstensberg Apr 7, 2017

Choose a reason for hiding this comment

pksjce commented Apr 9, 2017

okonet May 4, 2017

Choose a reason for hiding this comment

okonet May 4, 2017

Choose a reason for hiding this comment

okonet May 4, 2017

Choose a reason for hiding this comment

pksjce commented May 5, 2017

evenstensberg commented May 5, 2017 • edited Loading

evenstensberg commented May 5, 2017

addyosmani commented May 7, 2017

evenstensberg commented May 7, 2017 • edited Loading

evenstensberg commented May 7, 2017

kdzwinel commented May 7, 2017

addyosmani commented May 8, 2017

anyulled commented May 23, 2017

evenstensberg commented Jun 19, 2017

evenstensberg commented Apr 7, 2017 •

edited

Loading

evenstensberg commented May 5, 2017 •

edited

Loading

evenstensberg commented May 7, 2017 •

edited

Loading