Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests regex and add separate tests scripts in package.json #808

Closed
anshumanv opened this issue Mar 28, 2019 · 1 comment · Fixed by #809
Closed

Update tests regex and add separate tests scripts in package.json #808

anshumanv opened this issue Mar 28, 2019 · 1 comment · Fixed by #809

Comments

@anshumanv
Copy link
Member

Do you want to request a feature or report a bug?
bug: cli tests are never invoked

What is the current behavior?
No way to cli test for now since they are not included in tests regex

If the current behavior is a bug, please provide the steps to reproduce.

npm test

What is the expected behavior?
npm test won't tun tests from test/

If this is a feature request, what is motivation or use case for changing the behavior?
Need to run all tests

anshumanv added a commit to anshumanv/webpack-cli that referenced this issue Mar 28, 2019
updated test regex to include all tests, added some helper scripts

ISSUES CLOSED: webpack#808
@anshumanv
Copy link
Member Author

Do let me know if I'm missing anything here. 😄

anshumanv added a commit to anshumanv/webpack-cli that referenced this issue Mar 28, 2019
fix tests on node 6

ISSUES CLOSED: webpack#808
ematipico pushed a commit that referenced this issue Mar 29, 2019
ISSUES CLOSED: #808

<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. -->

**What kind of change does this PR introduce?**
Updated test regex to run all tests, added some helper scripts for running tests
<!-- E.g. a bugfix, feature, refactoring, build related change, etc… -->

**Did you add tests for your changes?**
Yes

**If relevant, did you update the documentation?**
Yes

**Summary**
* Updated tests regex to run all tests
* Added helper scripts to run cli and package tests separately
<!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? -->
<!-- Try to link to an open issue for more information. -->

**Does this PR introduce a breaking change?**
No
<!-- If this PR introduces a breaking change, please describe the impact and a migration path for existing applications. -->

**Other information**
misterdev pushed a commit to misterdev/webpack-cli that referenced this issue Apr 23, 2019
ISSUES CLOSED: webpack#808

<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. -->

**What kind of change does this PR introduce?**
Updated test regex to run all tests, added some helper scripts for running tests
<!-- E.g. a bugfix, feature, refactoring, build related change, etc… -->

**Did you add tests for your changes?**
Yes

**If relevant, did you update the documentation?**
Yes

**Summary**
* Updated tests regex to run all tests
* Added helper scripts to run cli and package tests separately
<!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? -->
<!-- Try to link to an open issue for more information. -->

**Does this PR introduce a breaking change?**
No
<!-- If this PR introduces a breaking change, please describe the impact and a migration path for existing applications. -->

**Other information**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant