Skip to content

Commit

Permalink
fix(serve): do not default host in webpack-dev-server v4
Browse files Browse the repository at this point in the history
  • Loading branch information
ylemkimon committed Nov 27, 2020
1 parent 1398295 commit 9d432a5
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/serve/src/startDevServer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ export default function startDevServer(compiler, cliOptions): object[] {
const usedPorts: number[] = [];
devServerOptions.forEach((devServerOpts): void => {
const options = mergeOptions(cliOptions, devServerOpts);
options.host = options.host || 'localhost';
// devSever v4 handles the default port itself
// devSever v4 handles the default host and port itself
if (!isDevServer4) {
options.host = options.host || 'localhost';
options.port = options.port || 8080;
}

Expand Down

0 comments on commit 9d432a5

Please sign in to comment.