fix: add todo

webpack · Dec 3, 2022 · 30dba1f · 30dba1f
1 parent 1571edd
commit 30dba1f
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/packages/webpack-cli/src/webpack-cli.ts b/packages/webpack-cli/src/webpack-cli.ts
@@ -2187,6 +2187,7 @@ class WebpackCLI implements IWebpackCLI {
     callback?: Callback<[Error | undefined, WebpackCLIStats | undefined]>,
   ): Promise<WebpackCompiler> {
     if (typeof options.defineProcessEnvNodeEnv === "string") {
+      // TODO: This should only set NODE_ENV for the runtime not for the config too. Change this during next breaking change.
       process.env.NODE_ENV = options.defineProcessEnvNodeEnv;
     } else if (typeof options.nodeEnv === "string") {
       process.env.NODE_ENV = options.nodeEnv;