GitHub Workflows security hardening #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex <[email protected]>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #370 +/- ##
==========================================
- Coverage 95.18% 92.85% -2.34%
==========================================
Files 40 43 +3
Lines 1661 2042 +381
Branches 0 598 +598
==========================================
+ Hits 1581 1896 +315
- Misses 80 118 +38
- Partials 0 28 +28 ☔ View full report in Codecov by Sentry. |
renovate bot
referenced
this pull request
in Unleash/unleash
Jun 22, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [enhanced-resolve](https://togithub.com/webpack/enhanced-resolve) | [`5.14.1` -> `5.15.0`](https://renovatebot.com/diffs/npm/enhanced-resolve/5.14.1/5.15.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>webpack/enhanced-resolve</summary> ### [`v5.15.0`](https://togithub.com/webpack/enhanced-resolve/releases/tag/v5.15.0) [Compare Source](https://togithub.com/webpack/enhanced-resolve/compare/v5.14.1...v5.15.0) #### New Features - Ignore `false`/`null`/`undefined` plugins by [@​alexander-akait](https://togithub.com/alexander-akait) in [https://github.com/webpack/enhanced-resolve/pull/389](https://togithub.com/webpack/enhanced-resolve/pull/389) #### Dependencies & Maintenance - GitHub Workflows security hardening by [@​sashashura](https://togithub.com/sashashura) in [https://github.com/webpack/enhanced-resolve/pull/370](https://togithub.com/webpack/enhanced-resolve/pull/370) - Add cSpell commit hook by [@​nschonni](https://togithub.com/nschonni) in [https://github.com/webpack/enhanced-resolve/pull/327](https://togithub.com/webpack/enhanced-resolve/pull/327) #### New Contributors - [@​sashashura](https://togithub.com/sashashura) made their first contribution in [https://github.com/webpack/enhanced-resolve/pull/370](https://togithub.com/webpack/enhanced-resolve/pull/370) **Full Changelog**: webpack/enhanced-resolve@v5.14.1...v5.15.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Unleash/unleash). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMzEuMCIsInVwZGF0ZWRJblZlciI6IjM1LjEzMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds explicit permissions section to workflows. This is a security best practice because by default workflows run with extended set of permissions (except from
on: pull_requestfrom external forks). By specifying any permission explicitly all others are set to none. By using the principle of least privilege the damage a compromised workflow can do (because of an injection or compromised third party tool or action) is restricted.It is recommended to have most strict permissions on the top level and grant write permissions on job level case by case.