Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(index): handle exception on loading invalid source maps (#65) #67

Merged
merged 2 commits into from
Jul 18, 2018

Conversation

fimius23
Copy link
Contributor

Added a try catch that's pretty much the same as the base64 fix.

@jsf-clabot
Copy link

jsf-clabot commented Jul 12, 2018

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please add test

@fimius23
Copy link
Contributor Author

fimius23 commented Jul 12, 2018

@jsf-clabot | @evilebottnawi | anyone else
In writing the tests I've noticed that the logic calls addDependency() once the file can be resolved. If there's an error parsing the source map should I remove the dependency?

@fimius23
Copy link
Contributor Author

Or I could just move the addDependency() call into the try?

@fimius23
Copy link
Contributor Author

I figured that since the dependency isn't removed if there's an error reading the file, then I don't need to worry about it.

@alexander-akait alexander-akait merged commit b65b76f into webpack-contrib:master Jul 18, 2018
@michael-ciniawsky
Copy link
Member

Released in v0.2.4 🎉

@michael-ciniawsky michael-ciniawsky changed the title fix: Handle exception on loading invalid source maps (#65) fix(index): handle exception on loading invalid source maps (#65) Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants