Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for dir-dependency message type #524

Merged
merged 1 commit into from
May 14, 2021
Merged

feat: add support for dir-dependency message type #524

merged 1 commit into from
May 14, 2021

Conversation

bradlc
Copy link
Contributor

@bradlc bradlc commented May 14, 2021

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

The PostCSS documentation has been updated to include a new dir-dependency message type. To my understanding of webpack this should be functionally equivalent to the existing context-dependency.

Side note: would it be possible to backport this to postcss-loader v4, so that webpack 4 users can benefit?

Please feel free to make any changes to this pull request.

@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #524 (fca959c) into master (d9c8a7e) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #524      +/-   ##
==========================================
+ Coverage   97.01%   97.04%   +0.03%     
==========================================
  Files           5        5              
  Lines         268      271       +3     
  Branches       87       88       +1     
==========================================
+ Hits          260      263       +3     
  Misses          8        8              
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9c8a7e...fca959c. Read the comment docs.

@alexander-akait
Copy link
Member

Please accept CLA

@bradlc
Copy link
Contributor Author

bradlc commented May 14, 2021

Please accept CLA

Done!

@alexander-akait alexander-akait merged commit 91dea60 into webpack-contrib:master May 14, 2021
@alexander-akait
Copy link
Member

Thanks

@bradlc
Copy link
Contributor Author

bradlc commented May 14, 2021

Thanks @alexander-akait! Do you have any thoughts on backporting dir-dependency support to postcss-loader 4 for webpack 4 compatibility?

@alexander-akait
Copy link
Member

We can do it, some developers till use tailwindcss under PostCSS v7 (just interesting)?

@bradlc
Copy link
Contributor Author

bradlc commented May 14, 2021

We can do it, some developers till use tailwindcss under PostCSS v7 (just interesting)?

Yes definitely! The @tailwindcss/postcss7-compat package gets over 200,000 weekly downloads.

@alexander-akait
Copy link
Member

Feel free to send PR to version-4 branch https://github.com/webpack-contrib/postcss-loader/branches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants