Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(karma-webpack): allow filename and chunkFilename to be overridden (config.output) #336

Merged
merged 1 commit into from
Aug 29, 2018
Merged

fix(karma-webpack): allow filename and chunkFilename to be overridden (config.output) #336

merged 1 commit into from
Aug 29, 2018

Conversation

Teamop
Copy link
Contributor

@Teamop Teamop commented Aug 10, 2018 •
edited by michael-ciniawsky
Loading

Type

  • Bugfix

Issues

SemVer

  • Fix (🏷 Patch)

Checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@jsf-clabot
Copy link

jsf-clabot commented Aug 10, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@michael-ciniawsky michael-ciniawsky changed the title fix(name): allow file and chunk name can be overridden fix(karma-webpack): allow filename and chunkFilename to be overridden Aug 14, 2018
@michael-ciniawsky michael-ciniawsky added this to the 3.0.1 milestone Aug 14, 2018
@michael-ciniawsky michael-ciniawsky changed the title fix(karma-webpack): allow filename and chunkFilename to be overridden fix(karma-webpack): allow filename and chunkFilename to be overridden (config.output) Aug 14, 2018
@michael-ciniawsky michael-ciniawsky mentioned this pull request Aug 29, 2018
Merged
3 tasks
michael-ciniawsky
michael-ciniawsky approved these changes Aug 29, 2018
View reviewed changes
Copy link
Contributor

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Teamop Thx

@michael-ciniawsky michael-ciniawsky merged commit c256d87 into codymikol:master Aug 29, 2018
@michael-ciniawsky
Copy link
Contributor

@Teamop Would you mind to open this PR against the next (v4.0.0) branch aswell ? :)

@Teamop
Copy link
Contributor Author

Teamop commented Aug 29, 2018

@michael-ciniawsky sure

@Teamop Teamop mentioned this pull request Aug 29, 2018
Closed
11 tasks
@Teamop
Copy link
Contributor Author

Teamop commented Aug 29, 2018

@michael-ciniawsky done, #339

@michael-ciniawsky
Copy link
Contributor

Released in v3.0.1 && v4.0.0-rc.0 🎉

This was referenced Sep 2, 2018
Closed
Closed
@michael-ciniawsky michael-ciniawsky removed this from the 3.0.1 milestone Sep 3, 2018
@cherewaty cherewaty mentioned this pull request Sep 5, 2018
Merged
@seanparmelee seanparmelee mentioned this pull request Jun 24, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Mar 9, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-ciniawsky michael-ciniawsky michael-ciniawsky approved these changes

@alexander-akait alexander-akait Awaiting requested review from alexander-akait

Assignees
No one assigned
Labels
semver: Patch status: Approved type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The output.filename should end with .js.
3 participants
@Teamop @jsf-clabot @michael-ciniawsky