Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(karma-webpack): allow filename and chunkFilename to be overridden (config.output) #339

Closed
wants to merge 6 commits into from

Conversation

Teamop
Copy link
Contributor

@Teamop Teamop commented Aug 29, 2018

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?
same PR as #336 against the next branch

Does this PR introduce a breaking change?

  • Yes
  • No

If this PR contains a breaking change, please describe the following...

  • Impact:
  • Migration path for existing applications:
  • Github Issue(s) this is regarding:

Other information:

@michael-ciniawsky michael-ciniawsky changed the title fix(name): allow file and chunk name can be overridden fix(karma-webpack): allow filename and chunkFilename to be overridden (config.output) Aug 29, 2018
Copy link
Contributor

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Teamop Thx

@michael-ciniawsky
Copy link
Contributor

I'm sry to have bothered you here, I'm an idiot and thought v3.0.0 was already on it's own branch which wasn't the case. This PR is now obsolete since I needed to rebase anyways :). My apologies again

@Teamop
Copy link
Contributor Author

Teamop commented Sep 1, 2018

Don't worry about it, thanks @michael-ciniawsky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants