Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better way to avoid optimize twice #457

Merged

Conversation

SyMind
Copy link
Contributor

@SyMind SyMind commented Nov 18, 2024

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Overwriting buildMeta is not supported in Rspack.

And, I think it would be better to use a WeakMap to map imageMinimizerPluginInfo for a module. Because the imageMinimizerPluginInfo only used in this plugin.

Breaking Changes

Additional Info

@SyMind SyMind force-pushed the better-for-avoid-optimize-twice branch from 21fa486 to 1a2cbb9 Compare November 18, 2024 10:56
@SyMind SyMind changed the title feat: better way for avoiding optimize twice feat: better way to avoid optimize twice Nov 18, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.79%. Comparing base (3a924e4) to head (72aa77f).
Report is 20 commits behind head on master.

Files with missing lines Patch % Lines
src/loader.js 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #457      +/-   ##
==========================================
+ Coverage   77.16%   77.79%   +0.62%     
==========================================
  Files           4        4              
  Lines         727      752      +25     
  Branches      282      302      +20     
==========================================
+ Hits          561      585      +24     
- Misses        137      138       +1     
  Partials       29       29              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@alexander-akait alexander-akait force-pushed the better-for-avoid-optimize-twice branch from a56b270 to 72aa77f Compare November 19, 2024 16:33
@alexander-akait alexander-akait merged commit 1b2d40e into webpack-contrib:master Nov 19, 2024
17 checks passed
@SyMind SyMind deleted the better-for-avoid-optimize-twice branch November 20, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants