Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(getOptions): deprecation warn in loaderUtils #114

Merged
merged 2 commits into from
Feb 24, 2017

Conversation

joshwiens
Copy link
Member

@joshwiens joshwiens commented Feb 24, 2017

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix

What is the current behavior? (You can also link to an open issue here)

loader-utils throws a deprecation warning

What is the new behavior?

updates from parseQuery to getOptions for loaderUtils

Does this PR introduce a breaking change?

  • Yes
  • No

If this PR contains a breaking change, please describe the following...

Other information:

Closes #113

@codecov
Copy link

codecov bot commented Feb 24, 2017

Codecov Report

Merging #114 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master    #114   +/-   ##
======================================
  Coverage    96.8%   96.8%           
======================================
  Files           2       2           
  Lines          94      94           
  Branches       17      18    +1     
======================================
  Hits           91      91           
  Misses          3       3
Impacted Files Coverage Δ
index.js 96.42% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c28052...efb47d8. Read the comment docs.

@bebraw
Copy link

bebraw commented Feb 24, 2017

LGTM.

@joshwiens joshwiens merged commit 5e12be4 into master Feb 24, 2017
@joshwiens joshwiens deleted the d3viant0ne-LoaderUtilsDepWarning branch February 24, 2017 18:22
joshwiens added a commit that referenced this pull request Jul 26, 2017
* fix(getOptions): deprecation warn in loaderUtils

* ci(Travis): removes osx build and node 5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic
2 participants