-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow webpack 3 as peer, use webpack 3 as devDep #144
Conversation
@@ -21,7 +21,7 @@ | |||
"tasks" | |||
], | |||
"peerDependencies": { | |||
"webpack": "^2.1.0-beta || ^2.2.0-rc || 2" | |||
"webpack": "^2.1.0-beta || ^2.2.0-rc || 2 || 3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could also allow the release candidate versions here if I change that to ^3.0.0-rc
but I'm not sure that's necessary now that 3.0.0
is out.
Codecov Report
@@ Coverage Diff @@
## master #144 +/- ##
=======================================
Coverage 67.64% 67.64%
=======================================
Files 8 8
Lines 204 204
Branches 52 52
=======================================
Hits 138 138
Misses 55 55
Partials 11 11 Continue to review full report at Codecov.
|
Thanks. |
@danez Can a patch release be made based on this PR? Otherwise this results in both webpack 2 & 3 being installed in |
the dev-dependency is for the tests. I will release a patch version. |
Thanks! |
@sokra @TheLarkInn
Since Webpack 3 has been released, this package should be updated to allow Webpack 3 as a peer dependency. Not really necessary, but I've also bumped the
devDependency
on Webpack to 3 as well.The API between Webpack 2 and 3 seems to be unchanged, so I'm not aware of any differences that would need to be accounted for in this package, it should just be a loosening of the
peerDependency
that's required.