-
-
Notifications
You must be signed in to change notification settings - Fork 257
build(travis): update minimum node v4.3.0...4.8.0 #204
Conversation
As described in npm/npm#18395 , npm 5.4 is incompatible with Node.js 4.3. Furthermore, per https://github.com/nodejs/Release , Node.js 4.3 is no longer supported, only the latest 4.x release (currently 4.8) is still in LTS. This change will ensure that all file-loader tests will start passing again, while keeping support for the broadest possible range of Node.js versions.
Codecov Report
@@ Coverage Diff @@
## master #204 +/- ##
=======================================
Coverage 96.96% 96.96%
=======================================
Files 2 2
Lines 33 33
Branches 16 16
=======================================
Hits 32 32
Misses 1 1 Continue to review full report at Codecov.
|
@d3viant0ne PTAL. This will fix tests for After this is (hopefully) merged, can we get this update into #183 , and look into merging that too? |
@@ -5,7 +5,7 @@ | |||
{ | |||
"useBuiltIns": true, | |||
"targets": { | |||
"node": "4.3" | |||
"node": "4.8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just node: '4'
?
@michael-ciniawsky So, I think the path forward on this PR is to wait for webpack-contrib/webpack-defaults#82 to be merged, then pull downstream just the changes (updating Travis, ignoring the others) to this repo? |
Yep, if webpack-contrib/webpack-defaults#82 lands, it's just update the |
@michael-ciniawsky Got it, thanks. |
Closing this, to wait for webpack-contrib/webpack-defaults#82 and an associated release of |
As described in npm/npm#18395 , npm 5.4 is incompatible with Node.js 4.3. Furthermore, per https://github.com/nodejs/Release , Node.js 4.3 is no longer supported, only the latest 4.x release (currently 4.8) is still in LTS.
This change will ensure that all
file-loader
tests will start passing again, while keeping support for the broadest possible range of Node.js versions.