Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash on split #63

Closed
wants to merge 1 commit into from
Closed

fix: crash on split #63

wants to merge 1 commit into from

Conversation

ricardogobbosouza
Copy link
Collaborator

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Fix #61

Breaking Changes

Additional Info

@codecov
Copy link

codecov bot commented Jan 19, 2021

Codecov Report

Merging #63 (5dc80fd) into master (d72a680) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #63   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          239       239           
  Branches        65        65           
=========================================
  Hits           239       239           
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d72a680...5dc80fd. Read the comment docs.

@mmmulani
Copy link

if module.resource is undefined, you'll end up with file === "undefined". It'll work but seems like bad form, why not just check that module.resource is valid or use ?.

@ricardogobbosouza ricardogobbosouza deleted the fix-split branch January 19, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read property 'split' of undefined
2 participants