-
-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove extra source map file + write source maps only if they are enabled #453
Conversation
The needed functionality has been extracted to a function.
Codecov Report
@@ Coverage Diff @@
## master #453 +/- ##
==========================================
+ Coverage 90.7% 98.19% +7.48%
==========================================
Files 10 9 -1
Lines 398 332 -66
Branches 85 75 -10
==========================================
- Hits 361 326 -35
+ Misses 37 6 -31
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to work for me, fixing the problem I was talking about here: #447 (comment) 👍
Published in |
Ok I've got some bad news... I just realized it doesn't work when the sourceMap option is present. I have to set
in the webpack options for this to be working. |
@fklingler That's confusing in #454 the opposite seems to be the case :D, can you show the bundle output and maybe make a small test repo for reproduction, there is a small bug somewhere. Please move the discussion to #454 aswell to keep it at one place 😛 |
What kind of change does this PR introduce?
Refactoring.
Did you add tests for your changes?
Old tests should work (had to tweak one).
Summary
This gets rid of the older hackfix.