Fix confusing paths in source maps #154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need the loader stuff in CSS source map sources
|
Still need to test it, but thx anyway 👍 |
|
I'm still seeing a similar issue when using both the autoprefixer-loader and sass-loader, with a webpack config setup like this project: https://github.com/erikras/react-redux-universal-hot-example The confusing paths are noted in this issue: Removing autoprefixer-loader from the chain results in normal looking sourcemap paths. Any ideas? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since CSS source maps are presented differently in the browser, we don't need the loader stuff in CSS source map sources. What do you think?
Before fix, paths (with the sass-loader) looked like:
After fix, paths look like:
Also fixes webpack-contrib/sass-loader#150