-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove shorts from Subscriptions tab #201
Conversation
Great work, keen to see this merged - shorts are a real pain point for me |
@FuriousBottle Is there any action needed from my side to have this PR merged? |
@JaCzekanski sorry for the confusion, I am just an admirer, I don't have any authority here 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR. I'll merge it after these things are addressed.
I tested the current "hardcoded path" approach and recursive search - the latter is slightly slower (~0.2ms on nodejs, mac), but we don't have to store the path so it should be more maintainable in the future. https://gist.github.com/JaCzekanski/7a35e15473d5bbe62056e6e03e3f5d17
|
219c7eb
to
392afb0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I would like to test it before merging though. I will try to make some time for YTAF this weekend.
I'm not really able to properly test the functionality, but at least it doesn't seem to break anything on K7Lp. |
Hello guys, please tell me when there will be an update with the function of hiding shorts, or now I can replace .js files in the file system via webos dev manager. But I don't know the way. Thanks for the information |
This PR adds filtering of JSON nodes containing
reelWatchEndpoint
which is an indicator that given video is a reel/short.Due to the convoluted format of JSON responses, it might not cover all of the cases.
Reel playback seems broken on TVs and I don't really care about having them, as it's ofter reused content.
Please note that it'll only work on the Subscriptions tab (which is the one I use the most).
However, It should be pretty easy to extend it to other tabs and search results.
Before:
After:
Green settings menu: