Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lost description in BuildSchema #253

Closed
wants to merge 1 commit into from
Closed

Fix lost description in BuildSchema #253

wants to merge 1 commit into from

Conversation

Poky85
Copy link
Contributor

@Poky85 Poky85 commented Feb 19, 2018

Right now description get lost when calling:

$source = AST::fromArray($array);
$schema = BuildSchema::build($source);

Mentioned in issues #201 and #88.

@Poky85 Poky85 mentioned this pull request Feb 19, 2018
Closed
@vladar
Copy link
Member

vladar commented Feb 19, 2018

Looks like this PR breaks some tests, can you please double check?

@vladar
Copy link
Member

vladar commented Mar 26, 2018

This should be fixed actually as a part of #248

@vladar vladar closed this Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Poky85 @vladar