Use Github actions with style #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BackEndTea
reviewed
Jan 18, 2021
tests/ProjectCodeTest.php
Outdated
| if (!$correct) { | ||
| $correct = in_array($fullMethodName, self::$mixinMethodNames, true); | ||
| } | ||
|
|
||
| if ($correct === false) { | ||
| if (false === $correct) { |
There was a problem hiding this comment.
Free to ignore: not really a fan of yoda conditionals, i'd prefer to skip that rule.
There was a problem hiding this comment.
I can see their value, but Im not in love with them.
This is reverted.
BackEndTea
approved these changes
Jan 18, 2021
|
Thank you for the review |
roelvanduijnhoven
pushed a commit
to roelvanduijnhoven/assert
that referenced
this pull request
Jan 25, 2021
* Update style * Update CI rules * Normalize composer.json * Disable yoda * Apply CS fixes
This was referenced Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.