PHP 8: method_exists() fixes and composer.json version constraint update
#207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ring|object PHP 8 throws `\TypeError` and `\ValueError` exceptions in internal functions (including `method_exists()`) when it encounters an invalid value. For `method_exists`, it expects `string|object`. See https://php.watch/versions/8.0/internal-function-exceptions `Assert::methodExists()` and `Assert::methodNotExists()` are updated to make sure the provided argument is string|object before calling `method_exist()` to avoid PHP 8 `\TypeError` exceptions.
31 tasks
|
Considering the tests don't need updating, and classes cant be numeric anyways i don't think this is a BC break, so this should be good to merge. I'm gonna keep the nightly build on allow failure for now, as it could break build if there is a 'bad' version on travis. |
|
Awesome, thanks a lot @BackEndTea . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: sebastianbergmann/phpunit#4325
PHP 8 builds are currently failing because
method_exists()calls throw exceptions if the argument is notstring|object. This PR fixes these calls by making sure the arguments arestring|objectbefore callingmethod_exists. This is because PHP 8 throws\TypeErrorand\ValueErrorexceptions from internal functions.In preparation for PHP 8, this PR also updates
composer.jsonPHP version constraint to allow PHP 8.All tests now pass on PHP 8 dev builds.