Prefix all function calls with a \ #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielBadura
approved these changes
Aug 1, 2019
This means PHP won't search the current namespace for a function first It also means PHP can use the Opcache (opcode?) for some functions, which is the actual speed increase. If possible i'd use the `use function` syntax, but that became available in php 5.6, and thus isn't an option atm.
BackEndTea
force-pushed
the
enhancement/function-prefix
branch
from
fd143bb to
e8ab511
Compare
BackEndTea
added a commit
that referenced
this pull request
Aug 9, 2019
This means PHP won't search the current namespace for a function first It also means PHP can use the Opcache (opcode?) for some functions, which is the actual speed increase. If possible i'd use the `use function` syntax, but that became available in php 5.6, and thus isn't an option atm.
BackEndTea
added a commit
that referenced
this pull request
Aug 9, 2019
This means PHP won't search the current namespace for a function first It also means PHP can use the Opcache (opcode?) for some functions, which is the actual speed increase. If possible i'd use the `use function` syntax, but that became available in php 5.6, and thus isn't an option atm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means PHP won't search the current namespace for a function first It also means that for some functions, php can use its opcode (on PHP 7.0+), which is an actual speed increase.
If possible i'd use the
use functionsyntax, but that became available in php 5.6, and thus isn't an option atm.For a relevant discussion about prefixes/opcodes see: PHP-CS-Fixer/PHP-CS-Fixer#3048 (comment)