[WIP] upgrade justinrainbow/json-schema dependancy to 2.0 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathroc
force-pushed
the
feature/json-schema-2.0
branch
3 times, most recently
from
909eb0e to
0e56d07
Compare
mathroc
force-pushed
the
feature/json-schema-2.0
branch
from
0e56d07 to
cee8876
Compare
|
Ping @webmozart. I have a valid schema that justinrainbow/json-schema 1.x can't understand but 2.x can, but as I'm using Puli this library enforces the older version. |
| @@ -10,7 +10,7 @@ | |||
| ], | |||
| "require": { | |||
| "php": "^5.3.3|^7.0", | |||
| "justinrainbow/json-schema": "^1.6", | |||
| "justinrainbow/json-schema": "^2.0", | |||
There was a problem hiding this comment.
Is there a way to support both versions?
|
Sorry, I'm not working on this anymore (I'm using justinrainbow/json-schema directly instead) |
|
No problem, I'll create a PR as it should be possible to support both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.