Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update anchor link for compute() after dropping synchronous execution support #596

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Update anchor link for compute() after dropping synchronous execution support #596

merged 1 commit into from
Mar 7, 2024

Conversation

ibelem
Copy link
Contributor

@ibelem ibelem commented Mar 7, 2024 •
edited by pr-preview bot
Loading

Fix #595 .

After dropping the support of synchronous execution in #531 , we'd better to update the anchor link of compute() from https://www.w3.org/TR/webnn/#api-mlcontext-async-execution to https://www.w3.org/TR/webnn/#api-mlcontext-compute .

Preview | Diff

anssiko
anssiko approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@anssiko anssiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ibelem thanks!

We usually don't tweak anchor names without a good reason, because cool URIs don't change, but in this case this change is justified.

This is a good example to highlight why selecting future-proof anchor names is important. Other spec might link here, resources such as MDN etc. So naming is not just bikeshedding here :-)

huningxin
huningxin approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix, @ibelem !

@anssiko anssiko merged commit 86081aa into webmachinelearning:main Mar 7, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Mar 7, 2024
@ibelem @github-actions
Update anchor link for compute() after dropping synchronous execution…
e70839a 
… support (#596)

SHA: 86081aa
Reason: push, by anssiko

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huningxin huningxin huningxin approved these changes

@anssiko anssiko anssiko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update anchor link for compute method
3 participants
@ibelem @anssiko @huningxin