Bug fix: resample2d output size calculation algorithm and usage #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huningxin
reviewed
Jan 24, 2024
* Per webmachinelearning#395 make it clearer that the algorithm is working on a new descriptor (a copy of the input's) * When invoking the algorithm, pass the required input argument. * Rename algorithm from "resample output sizes" to "calculate resample output sizes" which more clearly descripts what is happening and aligns with similar algorithms in the spec, and add types.
inexorabletash
force-pushed
the
bugfix-resample2d-output-sizes
branch
from
1e6f7e0 to
111172a
Compare
zolkis
approved these changes
Jan 25, 2024
wchao1115
approved these changes
Jan 27, 2024
github-actions bot
added a commit
that referenced
this pull request
Jan 27, 2024
SHA: 479ce17 Reason: push, by wchao1115 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
inexorabletash
added a commit
to inexorabletash/webnn
that referenced
this pull request
Jan 30, 2024
…achinelearning#520) * Per webmachinelearning#395 make it clearer that the algorithm is working on a new descriptor (a copy of the input's) * When invoking the algorithm, pass the required input argument. * Rename algorithm from "resample output sizes" to "calculate resample output sizes" which more clearly descripts what is happening and aligns with similar algorithms in the spec, and add types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per Use deep copy for setting internal slots? #395 make it clearer that the algorithm is working on a new descriptor (a copy of the input's)
When invoking the algorithm, pass the required input argument.
Rename algorithm from "resample output sizes" to "calculate resample output sizes" which more clearly descripts what is happening and aligns with similar algorithms in the spec.
Preview | Diff