Align algorithms defined so far #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to zk-conventions-integration
Signed-off-by: Zoltan Kis <[email protected]>
Squashed from the following commits:
Add reference to the platform operand object
Address review comment, change note.
Signed-off-by: Zoltan Kis <[email protected]>
Signed-off-by: Zoltan Kis <[email protected]>
Signed-off-by: Zoltan Kis <[email protected]>
Signed-off-by: Zoltan Kis <[email protected]>
Squashed from the following commits:
Replace MLOperand.[[descriptor]] with type and dimensions
Clarify the algorithm for only setting up the op
Improve the clamp() algorithm, use the prose assuming the create steps for MLOperand and MLActivation
Rework clamp with polymorphic behavior. Update for changes in MLOperand.
Rework clamp() like constant(), polymorphic forms in separate sections, argument and return descriptions as notes.
Fix platform related steps and reference to internal slots
Address review, remove note
Remove back quotes from title
Signed-off-by: Zoltan Kis <[email protected]>
Signed-off-by: Zoltan Kis <[email protected]>
Signed-off-by: Zoltan Kis <[email protected]>
Signed-off-by: Zoltan Kis <[email protected]>
…ing algorithms Signed-off-by: Zoltan Kis <[email protected]>
Signed-off-by: Zoltan Kis <[email protected]>
…s/webnn into zk-conventions-integration
Signed-off-by: Zoltan Kis <[email protected]>
huningxin
reviewed
Jun 21, 2023
huningxin
reviewed
Jun 21, 2023
huningxin
reviewed
Jun 21, 2023
…, clamp, concat, batch norm Signed-off-by: Zoltan Kis <[email protected]>
zolkis
commented
Jun 21, 2023
Signed-off-by: Zoltan Kis <[email protected]>
|
(Merging this PR to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the improved platform specific steps developed for clamp(), update the algorithms defined so far: input, constant, clamp, concat, batch norm, and the create activation steps.
This is to figure out the best steps to be also applied to subsequent algorithms.
@huningxin PTAL
Because the main branch was also merged, a lot of commits appear here, but only this one is relevant:
8fac5ca
Preview | Diff