Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add constructor steps to MLGraphBuilder #309

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

zolkis
Copy link
Collaborator

@zolkis zolkis commented Dec 8, 2022

Cherry-picked from #301 to help reviewing.
It refers to (missing) steps for validating MLContext, which will be added in a separate PR.
It is marked as an issue.

@anssiko @wchao1115 @huningxin


Preview | Diff

Copy link
Member

@anssiko anssiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

(It seems the CI auto-publish failure is unrelated.)

Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @zolkis !

@anssiko
Copy link
Member

anssiko commented Dec 9, 2022

Ready to merge. Thanks @zolkis @huningxin!

@anssiko anssiko merged commit 70fc272 into webmachinelearning:main Dec 9, 2022
github-actions bot added a commit that referenced this pull request Dec 9, 2022
SHA: 70fc272
Reason: push, by anssiko

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@zolkis zolkis mentioned this pull request Dec 10, 2022
@zolkis zolkis deleted the graphbuilder-constructor branch January 18, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants