Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: improve titles by including interface/method/dict etc. #305

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

zolkis
Copy link
Collaborator

@zolkis zolkis commented Dec 1, 2022

This is to align with other W3C specification prose. Trivial merge.
Feel free to edit/add commits.

@huningxin @wchao1115


Preview | Diff

@zolkis zolkis mentioned this pull request Dec 1, 2022
index.bs Show resolved Hide resolved
@@ -1248,7 +1248,7 @@ partial interface MLGraphBuilder {
- *pow*: Compute the values of the values of the first input tensor to the power of the values of the second input tensor, element-wise.
</div>

### element-wise unary operations ### {#api-mlgraphbuilder-unary}
### Element-wise unary operations ### {#api-mlgraphbuilder-unary}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same argument as above. I suggest either keeping the generic section name, or split up to subsections for each method.

Copy link
Member

@anssiko anssiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will handle "element-wise binary operations" and "element-wise unary operations" updates in a separate PR.

@anssiko anssiko merged commit 8ac6b40 into webmachinelearning:main Dec 8, 2022
github-actions bot added a commit that referenced this pull request Dec 8, 2022
SHA: 8ac6b40
Reason: push, by anssiko

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@zolkis zolkis deleted the improve-titles branch December 8, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants