Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buildAsync method for async graph compilation #266

Merged
merged 2 commits into from
May 20, 2022

Conversation

huningxin
Copy link
Contributor

@huningxin huningxin commented May 7, 2022

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
Copy link

@wacky6 wacky6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm / a few suggestions on phrasing

@huningxin
Copy link
Contributor Author

Thanks @wacky6 for review and suggestion. I've fixed those in the new commit ac146e9. Please take another look.

Copy link

@wacky6 wacky6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@anssiko anssiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @huningxin, for discussion on today's call.

Related, for this method and others, we should add the method steps per #210. I won't block this PR on that because we track that separately.

@huningxin
Copy link
Contributor Author

huningxin commented May 20, 2022

Related, for this method and others, we should add the method steps per #210. I won't block this PR on that because we track that separately.

Acknowledged that, thanks @anssiko . Let's add the method steps in a separate PR.

And thanks all for review and approvals. With that, I am going to merge it.

@huningxin huningxin merged commit e9b9e2c into webmachinelearning:main May 20, 2022
github-actions bot added a commit that referenced this pull request May 20, 2022
SHA: e9b9e2c
Reason: push, by @huningxin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support asynchronous graph compilation
4 participants