-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename MLOperandDescriptor
's dimensions
to shape
#669
Comments
As proposed in webmachinelearning/webnn#669 This CL was created exclusively using targeted find-and-replaces, followed by running git cl format. This CL has no behavioral changes, though it is a breaking change for ~all consumers of WebNN Cq-Include-Trybots: luci.chromium.try:mac14-blink-rel,mac14.arm64-blink-rel,win11-blink-rel Change-Id: I6b37ebc505a37686709f006b3ecafcefd3e2016d
As proposed in webmachinelearning/webnn#669 This CL was created exclusively using targeted find-and-replaces, followed by running git cl format. This CL has no behavioral changes, though it is a breaking change for ~all consumers of WebNN Bug: 365813262 Cq-Include-Trybots: luci.chromium.try:mac14-blink-rel,mac14.arm64-blink-rel,win11-blink-rel Change-Id: I6b37ebc505a37686709f006b3ecafcefd3e2016d
As proposed in webmachinelearning/webnn#669 This CL was created exclusively using targeted find-and-replaces, followed by running git cl format. This CL has no behavioral changes, though it is a breaking change for ~all consumers of WebNN Bug: 365813262 Cq-Include-Trybots: luci.chromium.try:mac14-blink-rel,mac14.arm64-blink-rel,win11-blink-rel Change-Id: I6b37ebc505a37686709f006b3ecafcefd3e2016d
Seems like a tossup, as "dimensions" is widely used by ML libraries too: XNNPACK
Interestingly that ambiguity also applies to a field named Updated my comment with everyone's pro's/con's statements so far, but I have one other idea on #676 (comment)... 🔍. |
Using |
As discussed in #666:
"shape" is the more widely used term, so I propose we align on that. WDYT?
The text was updated successfully, but these errors were encountered: