Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing conv2d validation steps #439

Closed
zolkis opened this issue Jul 6, 2023 · 0 comments
Closed

Add missing conv2d validation steps #439

zolkis opened this issue Jul 6, 2023 · 0 comments

Comments

@zolkis
Copy link
Collaborator

zolkis commented Jul 6, 2023

          @zolkis For options, how about adding the validation steps for the `else` condition?  

If options.strides is undefined, set it to [1, 1].

If options.[strides] is undefined, set it to [1, 1]. else if options.strides.size() != 2 or any element in strides is equal to 0, throw error.
For detailed algorithm, please refer to the implementation in chromium code- https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/ml/webnn/ml_graph_builder.cc;l=202.

Originally posted by @lisa0314 in #407 (comment)

zolkis added a commit to zolkis/webnn that referenced this issue Jul 12, 2023
anssiko added a commit that referenced this issue Aug 10, 2023
…rithms

Fix #439: add missing conv2d() and convTranspose2d() validation steps
@zolkis zolkis closed this as completed Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant