Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guidelines/philosophy for new operations, including security principles #242

Closed
quidity opened this issue Dec 22, 2021 · 2 comments
Closed
Labels
security-tracker Group bringing to attention of security, or tracked by the security Group but not needing response.

Comments

@quidity
Copy link

quidity commented Dec 22, 2021

The universe of operations supported by this spec is likely to grow in the future.

To ensure that new operators are shaped in a way that they can be implemented securely, it would be good to include some general guidelines/philosophy on how ops are defined to reduce potential for ops to result in implementation problems.

For instance, avoid reshaping tensors, simplicity of arguments, no parsers for complex data formats.

@anssiko anssiko added the security-tracker Group bringing to attention of security, or tracked by the security Group but not needing response. label Dec 22, 2021
@anssiko
Copy link
Member

anssiko commented Jan 31, 2022

The group discussed this issue and agreed to add "secure by design" guidelines to the spec (possibly to the MLOperand section, cross-linked to dedicated security section as appropriate).

Related, we received general guidelines from the ONNX project and will incorporate also this perspective along with the security-focused guidelines.

anssiko added a commit that referenced this issue Feb 17, 2022
@anssiko
Copy link
Member

anssiko commented Feb 17, 2022

I pushed 4549a67 to PR #251 to add "Guidelines for new operations" section as proposed.

This incorporates input from @quidity as well as from the ONNX project shared at our TPAC 2021 meeting, and some other proposals I thought might be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security-tracker Group bringing to attention of security, or tracked by the security Group but not needing response.
Projects
None yet
Development

No branches or pull requests

2 participants