-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add steps for running WebNN NPU #232
Conversation
README.md
Outdated
Edge browser will download the latest DirectML.dll automatically when WebNN is enabled. | ||
3. Launch your browser in Windows Command Line: | ||
* For Google Chrome Canary: | ||
> "C:\Users\\"username"\AppData\Local\Google\Chrome SxS\Application\chrome.exe" --disable-gpu-sandbox |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@huningxin @mingmingtasd Do we have to use the '--disable-gpu-sandbox' flag? I mean the minimal impact flag the better, only use "--use-redist-dml" will not help, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only use "--use-redist-dml" is OK for chrome canary. I also removed the flag for edge canary, is that OK? Should rely on edge itself to download the latest dml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have to use the '--disable-gpu-sandbox' flag?
Interesting, a new flag to add to the list. I suppose that's a narrower form of --no-sandbox
that only applies to the GPU process.
@huningxin @Honry do you have any comments for merging this PR? Thanks |
Upload a new commit, PTAL, thanks! @ibelem @Honry @huningxin |
f142ee4
to
86a1085
Compare
Updated to address your comments, PTAL again, thanks! @huningxin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with two minor comments.
0ce9a8e
to
655cd2e
Compare
PTAL, thanks! @Honry @huningxin @ibelem