Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should languagePairAvailable() accept {sourceLanguage, targetLanguage} instead of two parameters? #24

Open
tomayac opened this issue Nov 28, 2024 · 0 comments · May be fixed by #31
Open

Should languagePairAvailable() accept {sourceLanguage, targetLanguage} instead of two parameters? #24

tomayac opened this issue Nov 28, 2024 · 0 comments · May be fixed by #31

Comments

@tomayac
Copy link

tomayac commented Nov 28, 2024

Developers need to pass {sourceLanguage, targetLanguage} at the create() step anyway, so maybe languagePairAvailable() should follow the same format. This also avoids confusion with the two parameters: is the source language the first or the second parameter?
domenic added a commit that referenced this issue Dec 11, 2024
@domenic
Remove the capabilities objects
c320383 
Instead, we replace them with createOptionsAvailable() for translator, and canDetect() for language detector.

Closes #24.
@domenic domenic linked a pull request Dec 11, 2024 that will close this issue
Open
domenic added a commit that referenced this issue Dec 11, 2024
@domenic
Remove the capabilities objects
6981c9c 
Instead, we replace them with createOptionsAvailable() for translator, and canDetect() for language detector.

Closes #24.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@tomayac