-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Syntax Highlight and automatic formatting of JSON and XML #61
Conversation
@fredsted This works as I test it: |
@@ -1,4 +1,5 @@ | |||
@import "node_modules/bootstrap-sass/assets/stylesheets/bootstrap"; | |||
@import "node_modules/highlight.js/styles/github"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fredsted Are you happy with this as default style? Not sure what you wanted to use here; being able to choose would be great but added a level of complexity (plus additional preference to have somewhere)
I personally prefer a dark style
Looks awesome! Great work. I think a lot of users will be happy about the XML formatting. Regarding the theme, I'd like to keep it a bright theme so it fits with the rest of the app. I think an app-wide dark mode toggle would be nice. |
Awesome, I haven't had a chance to test the limits of the formatters, but if you're happy with it go ahead and merge 👍 |
Gave it a spin, and the only minor thing is that the formatting can't be toggled on/off immediately on the checkbox - if I want to see how the request looks unformatted, I have to turn formatting off and click back to another request. For me that's useful when you want to see exactly what's returned from the webhook. I might try to fix this myself, but going to merge this for now. Thanks again! |
Adds support for syntax highlighting of XML and JSON files (#5)
Fixes #5
Fixes #60