Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker-compose.yml #100

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Update docker-compose.yml #100

merged 1 commit into from
Mar 3, 2022

Conversation

spurin
Copy link
Contributor

@spurin spurin commented Dec 24, 2020

Complements on an awesome project. I was testing this in an environment where I had two redis servers running and noticed that ECHO_REDIS_HOST wasn't accepted in the compose file. Looks like at some point, this has changed to ECHO_REDIS_HOSTNAME -

For reference, here is the laravel-echo-server.example.json file that is sourced and changed, during startup of the laravel-echo-server container -

# cat laravel-echo-server.example.json
{
	"authHost": "http://localhost",
	"authEndpoint": "/broadcasting/auth",
	"clients": {{ ECHO_CLIENTS }},
	"database": "redis",
	"databaseConfig": {
		"redis": {
      "port": "{{ ECHO_REDIS_PORT }}",
      "host": "{{ ECHO_REDIS_HOSTNAME }}"
		}
	},
	"devMode": "{{ ECHO_DEVMODE }}",
	"host": null,
	"port": "6001",
	"protocol": "{{ ECHO_PROTOCOL }}",
	"socketio": {},
	"sslCertPath": "{{ ECHO_SSL_CERT_PATH }}",
	"sslKeyPath": "{{ ECHO_SSL_KEY_PATH }}",
	"sslCertChainPath": "{{ ECHO_SSL_CHAIN_PATH }}",
	"sslPassphrase": "{{ ECHO_SSL_PASSPHRASE }}",
	"apiOriginAllow": {
		"allowCors": {{ ECHO_ALLOW_CORS }},
		"allowOrigin": "{{ ECHO_ALLOW_ORIGIN }}",
		"allowMethods": "{{ ECHO_ALLOW_METHODS }}",
		"allowHeaders": "{{ ECHO_ALLOW_HEADERS }}"
	}

Sourced value is ECHO_REDIS_HOSTNAME, rather than ECHO_REDIS_HOST -

```
# cat laravel-echo-server.example.json
{
	"authHost": "http://localhost",
	"authEndpoint": "/broadcasting/auth",
	"clients": {{ ECHO_CLIENTS }},
	"database": "redis",
	"databaseConfig": {
		"redis": {
      "port": "{{ ECHO_REDIS_PORT }}",
      "host": "{{ ECHO_REDIS_HOSTNAME }}"
		}
	},
	"devMode": "{{ ECHO_DEVMODE }}",
	"host": null,
	"port": "6001",
	"protocol": "{{ ECHO_PROTOCOL }}",
	"socketio": {},
	"sslCertPath": "{{ ECHO_SSL_CERT_PATH }}",
	"sslKeyPath": "{{ ECHO_SSL_KEY_PATH }}",
	"sslCertChainPath": "{{ ECHO_SSL_CHAIN_PATH }}",
	"sslPassphrase": "{{ ECHO_SSL_PASSPHRASE }}",
	"apiOriginAllow": {
		"allowCors": {{ ECHO_ALLOW_CORS }},
		"allowOrigin": "{{ ECHO_ALLOW_ORIGIN }}",
		"allowMethods": "{{ ECHO_ALLOW_METHODS }}",
		"allowHeaders": "{{ ECHO_ALLOW_HEADERS }}"
	}
```
@fredsted fredsted merged commit 28bc08d into webhooksite:master Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants