Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit the process with error code when unhandled rejection #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marvinroger
Copy link

Running whcli with, for example, an invalid token, exits with 0, e.g.:

whcli forward --token=faceb236-ad99-463c-bd78-57e872d18b31 --target=http://localhost

This PR adds a process.exit(1); to the unhandledRejection handler, which is the default behavior in Node.js.
Also, I removed the process.abort() which I think is never called because the following process.exit runs right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant