Breaking: Make rawResponse a Promise<Buffer>
#534
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molant
requested review from
alrra,
austinkelleher and
sarvaje
as code owners
With `debugging protocol` connectors we need to do another request to get the raw bytes of the response. With this change `sonar` will only do the extra request when is needed, caching the result for later use. - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - Fix #164
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
debugging protocolconnectors we need to do another request toget the raw bytes of the response. With this change
sonarwill onlydo the extra request when is needed, caching the result for later use.
Fix #164