-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Update Code of Conduct links #450
Conversation
Link to CoC on JS Foundation website to ensure it is always up to date and includes the full CoC including the committee, enforcement details, etc.
@kborchers How often is that changed? See also: #353 |
@alrra It's not changed often, if ever, but we also don't track all of these other versions so if it does change, yours would be outdated. More importantly, the CoC includes a number of other pages with more information about the committee, enforcement of the code, etc that it is important people read as well so by linking directly to the JSF version, there is no question if people were given the full CoC to review. |
@kborchers Maybe keep the |
Not sure that's absolutely necessary since the CoC is linked in the README but if the team prefers that, I'm fine with it. |
@sonarwhal/contributors ⬆️ |
Linking directly seems okay to me when I first tried it out, but I'm not sure if it is best practice to link to pages in other domain from the navigation bar. Also if we do decide to link directly, maybe we can consider redirecting https://sonarwhal.com/about/code_of_conduct.html to https://js.foundation/community/code-of-conduct so that 404 won't show? |
My concern: The
Yes. |
I think getting the conduct link back is important so I would say we should add The sonar project follows the JS Foundation Code of Conduct |
That seems like the best solution to me as well. Any bots that want to see the file will be satisfied, but you won't have to duplicate the CoC. |
The `CODE_OF_CONDUCT.md` file has become something of a "standard", being used by GitHub in a number of places, and possible other bots. - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - ¹ #353 https://github.com/sonarwhal/sonar/community https://opensource.guide/code-of-conduct/ ² #450 (comment) Ref #450 Fix #450
Done in ca849a3. |
Link to CoC on JS Foundation website to ensure it is always up to
date and includes the full CoC including the committee,
enforcement details, etc.