Add rule to check if opener was disowned #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
molant
reviewed
May 2, 2017
| * The reason why the rule does not check the same origin links by | ||
| default is because: | ||
|
|
||
| * security isn't really a problem here |
| </map> | ||
| </body> | ||
| </html>` | ||
| ``` |
There was a problem hiding this comment.
Maybe add here that this rule will be triggered only one by <a href="http://example2.com" target="_blank">test</a> ?
There was a problem hiding this comment.
I've updated the examples. Let me know what you think.
|
|
||
| const ruleName = getRuleName(__dirname); | ||
|
|
||
| const generateHTML = (body: string): string => { |
There was a problem hiding this comment.
Should we put this as a helper for all rules and accept head and body (with empty strings as defaults)?
There was a problem hiding this comment.
Will do that as part of #162.
molant
approved these changes
May 2, 2017
alrra
added a commit
that referenced
this pull request
May 5, 2017
alrra
added a commit
that referenced
this pull request
May 6, 2017
This was referenced Feb 1, 2020
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #149