Add test to sonar.ts #154
Merged
Add test to sonar.ts #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alrra
reviewed
Apr 21, 2017
tests/lib/sonar.ts
Outdated
| t.false(t.context.resourceLoader.getRules.called); | ||
| }); | ||
|
|
||
| test('If conflig.plugins is an array we should create just those plugins', (t) => { |
tests/lib/sonar.ts
Outdated
| t.is(t.context.eventemitter.prototype.on.args[2][0], 'fetch::error'); | ||
| }); | ||
|
|
||
| test('If conflig.rules is an array of ids we should create just those rules', (t) => { |
tests/lib/sonar.ts
Outdated
| t.is(sonarObject.pageContent, html); | ||
| }); | ||
|
|
||
| test.serial('pageHeaders should return the HTML', async (t) => { |
There was a problem hiding this comment.
should return the page's response headers
tests/lib/sonar.ts
Outdated
|
|
||
| import test from 'ava'; | ||
| import * as sinon from 'sinon'; | ||
| import * as proxyquire from 'proxyquire'; |
There was a problem hiding this comment.
import * as proxyquire from 'proxyquire';
import * as sinon from 'sinon';
import test from 'ava';
Fix how plugins are loaded Activate eol-last in eslint rules -------------------------- Fix #5
Haha Note: You can also make your text editor/IDE take into account the properties from the |
|
@alrra I thought that vscode took int account the .editorconfig... I've just installed a plugin to use it :) |
This was referenced Sep 15, 2021
This was referenced Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix how we load plugins
Fix #5