-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Http-compression of small files #4031
Comments
Hello @gottfridsberg, can you please provide more information about what issue are you experiencing with |
Sorry for the incomplete (missing) bug repport. The tested site has a few files that are smaller than 500b, but I still get http-compression hints. URL: https://www.tomasmoberg.org http-compression: 6 hints hint #1: Response should be compressed with gzip when gzip compression is requested. hint #2: Response should be compressed with Brotli when Brotli compression is requested over HTTPS. hint #3: Response should be compressed with Zopfli when gzip compression is requested. hint #4: Response should be compressed with Zopfli when gzip compression is requested. hint #5: Response should be compressed with gzip when gzip compression is requested. hint #6: Response should be compressed with Brotli when Brotli compression is requested over HTTPS. |
Thanks for the additional detail @gottfridsberg! @molant - looks like |
What do you think of changing the severity if the files are under the threshold? I think the cutoff size depends a lot if you are using HTTP2 or not, the size of the headers, if it's the first resource from a given domain (and all the price that you need to pay for shaking and such). From a quick search it seems:
While headers seem to take about half the size of the package, I think that rounding to 1KB the threshold seems reasonable. |
Depends on the severity. If we're going to show anything I'd say no stronger than a "hint" - "warning" seems like too much. That said, I think I'd prefer nothing at all unless there are a lot of small, uncompressed files (though I know that's harder to account for given the way the hint is written). |
I was thinking on hint. Definitely not warning. |
I have started working on this and I have just realized that IIRC, the online scanner is going to show all the issues regardless of their severities, so if we just change the severity to |
@sarvaje I'm okay with these still appearing in the online scanner initially. I'd rather separately get that updated to correctly communicate severity as opposed to working around the limitation at the hint level. |
No description provided.
The text was updated successfully, but these errors were encountered: