Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

depthClearValue is undefined iff NaN #467

Merged
merged 3 commits into from
Dec 11, 2024
Merged

depthClearValue is undefined iff NaN #467

merged 3 commits into from
Dec 11, 2024

Conversation

kainino0x
Copy link
Collaborator

@kainino0x kainino0x commented Dec 9, 2024 •
edited
Loading

API documentation.

Issue: #427
See also #466 for the behavior of infinities

@kainino0x kainino0x requested a review from lokokung December 9, 2024 22:54
@kainino0x kainino0x mentioned this pull request Dec 9, 2024
Open
10 tasks
@eliemichel
Copy link
Collaborator

Maybe we should recall here that WGPU_DEPTH_CLEAR_VALUE_UNDEFINED is NaN and so that one SHALL use isnan() rather than depthClearValue == WGPU_DEPTH_CLEAR_VALUE_UNDEFINED?

@kainino0x kainino0x enabled auto-merge (squash) December 11, 2024 19:18
@kainino0x kainino0x merged commit c2b2d77 into webgpu-native:main Dec 11, 2024
5 checks passed
@kainino0x kainino0x deleted the isnan branch December 13, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliemichel eliemichel eliemichel approved these changes

@lokokung lokokung Awaiting requested review from lokokung

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kainino0x @eliemichel