Deduplicate TimestampWrites structs #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we need to extend TimestampWrites (e.g. with
end of vertex stageor something) then we can still extend them off this struct, we'll just allow different extensions in different places.(I previously wanted to avoid the allowed extensions being dependent on where the base struct is used, with extensibility of WGPUImageCopyTexture etc., but here it makes a lot more sense IMO as we have a much more concrete idea of what the extensions would be, and some could be shared. Still open to opinions if anyone thinks we should avoid this.)
Fixes #430