Remove DeviceLost status from WGPUSurfaceGetCurrentTextureStatus #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We didn't discuss which status we would use for this but "Lost" makes sense. Issue webgpu-native#209
52 tasks
|
Technically the connection to the X server being severed, and the device being lost are two different things. But IDK that an application can usefully handle one while not handling the other so LGTM. |
Kangz
approved these changes
Nov 12, 2024
kainino0x
force-pushed
the
surface-device-lost
branch
from
176d1bb to
ea73652
Compare
|
I just realized... in JS if you getCurrentTexture on a lost device, you just get an invalid texture (well, a texture that you can't observe is valid, because the device is lost). That is probably needs to be done here, to match - it's not exactly possible in JS or on remoting implementations to do what I wrote here, because you don't know synchronously when the device is lost. Hopefully this isn't a problem for non-remoting native.... Revised. |
Kangz
reviewed
Nov 14, 2024
doc/articles/Surfaces.md
Outdated
| @@ -242,8 +242,8 @@ The behavior of `::wgpuSurfaceGetCurrentTexture``(surface, surfaceTexture)` is: | |||
| - Validate that `surface.config` is not `None`. | |||
| - Validate that `surface.currentFrame` is `None`. | |||
|
|
|||
| - If `surface.config.device` is not alive, set `surfaceTexture->status` to `WGPUSurfaceGetCurrentTextureStatus_DeviceLost` and return. | |||
| - If the implementation detects any other problem preventing use of the surface, set `surfaceTexture->status` to an appropriate status (something other than `SuccessOptimal`, `SuccessSuboptimal`, `Error`, or `DeviceLost`) and return. | |||
| - If `surface.config.device` is not alive, set `surfaceTexture->status` to `WGPUSurfaceGetCurrentTextureStatus_Success`, set `surfaceTexture->texture` to a new invalid `WGPUTexture`, and return. | |||
There was a problem hiding this comment.
We should still have the correct reflection on that texture.
Kangz
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't discuss which status we would use for this, but "Lost" seems to makes sense.This should behave like JS where we pretend it worked by returning a texture, but you can't use it because the device is lost.
Issue #209