Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[proposal] Change SetBlendConstant to take 4 floats #394

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[proposal] Change SetBlendConstant to take 4 floats #394

wants to merge 1 commit into from

Conversation

kainino0x
Copy link
Collaborator

@kainino0x kainino0x commented Nov 9, 2024 •
edited
Loading

Fixes #378 (dawn bug: TODO)

@kainino0x kainino0x requested a review from lokokung November 9, 2024 02:26
lokokung
lokokung approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@lokokung lokokung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can we file a Dawn side bug to update this as well? (I don't think it exists atm?)

@kainino0x
Copy link
Collaborator Author

I'll be sure to file it if we decide to make this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lokokung lokokung lokokung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should SetBlendConstant take float,float,float,float instead of WGPUColor?
2 participants
@kainino0x @lokokung