Add docs on ownership #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also generate docs for function parameters.
lokokung
approved these changes
Oct 17, 2024
| "description": "Ownership of the value", | ||
| "enum": [ | ||
| "with", | ||
| "without" |
There was a problem hiding this comment.
Some bikeshedding... with and without feel a bit implicit? What if we used something more explicit like application vs api?
There was a problem hiding this comment.
Whoops I shouldn't have enabled automerge. Was thinking of that too, but used "With" and "Without" to match the ownership article. Maybe with_ownership: boolean?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also generate docs for function parameters.
I think these are the last of the docs for #143 and #326. I probably missed a few places that need ownership docs but this should be most of them.