Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fold DepthClipControl into PrimitiveState #311

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

beaufortfrancois
Copy link
Contributor

@beaufortfrancois
Copy link
Contributor Author

Please review

@kainino0x kainino0x self-requested a review July 18, 2024 06:42
Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, missed this review. LGTM, thanks!

@kainino0x kainino0x enabled auto-merge (squash) July 18, 2024 06:47
@kainino0x kainino0x merged commit 7b1bed0 into webgpu-native:main Jul 18, 2024
4 checks passed
@beaufortfrancois beaufortfrancois deleted the DepthClipControl branch July 22, 2024 08:44
aarongable pushed a commit to chromium/chromium that referenced this pull request Jul 22, 2024
- No operational changes.

webgpu-native/webgpu-headers#311

Bug: 42241174
Change-Id: I8d8016eff16876d8ef13f4840578fec2049e906a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5688517
Reviewed-by: Corentin Wallez <[email protected]>
Commit-Queue: Fr <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1330988}
copybara-service bot pushed a commit to google/dawn that referenced this pull request Jul 29, 2024
The following CL must be merged before:
- https://chromium-review.googlesource.com/c/chromium/src/+/5688517

webgpu-native/webgpu-headers#311

Bug: 42241174
Change-Id: Ia425ba7a25494e9dcb96de0492d045c670f8f30c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/197634
Commit-Queue: Fr <[email protected]>
Reviewed-by: Kai Ninomiya (OOO until 8月23日) <[email protected]>
aarongable pushed a commit to chromium/chromium that referenced this pull request Jul 31, 2024
- No operational changes.

webgpu-native/webgpu-headers#311

Bug: 42241174
Change-Id: If4fad0a3d2a509d386539255905b35bfa5befd83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5748571
Reviewed-by: Corentin Wallez <[email protected]>
Commit-Queue: Fr <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1335406}
copybara-service bot pushed a commit to google/dawn that referenced this pull request Sep 2, 2024
webgpu-native/webgpu-headers#311

Bug: 42241174

Change-Id: I4488d6d54c46fadfbf288c7f235d4d53e6321d25
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/204634
Commit-Queue: Corentin Wallez <[email protected]>
Reviewed-by: Corentin Wallez <[email protected]>
Commit-Queue: Fr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants