Replace wgpuAdapterRequestAdapterInfo with wgpuAdapterGetInfo #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kainino0x
approved these changes
May 28, 2024
copybara-service bot
pushed a commit
to google/dawn
that referenced
this pull request
May 29, 2024
Following up on a webgpu.h change[1], this CL adds support for wgpuAdapterGetInfo and wgpuAdapterInfoFreeMembers to mimic the GPUAdapter info attribute in the JavaScript API. [1]: webgpu-native/webgpu-headers#296 Bug: 335383516 Change-Id: Ic93bd8a45f5051330801fe5a84b3663eb1f9c2b2 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/190380 Reviewed-by: Kai Ninomiya <[email protected]> Commit-Queue: Fr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #266 (comment), this PR replaces
wgpuAdapterRequestAdapterInfowithwgpuAdapterGetInfoand adds new fields inWGPUAdapterInfo